From f15db30fb9b15fc1e2ec0f096e9339df223bbcae Mon Sep 17 00:00:00 2001
From: TennesseeTrash <vitosoukup@gmail.com>
Date: Sun, 15 Jun 2025 22:21:23 +0200
Subject: [PATCH] [Tablegen] Use a references, instead of copies

---
 Libraries/Tablegen/Include/Tablegen/Tablegen.hpp | 9 +++++----
 Libraries/Tablegen/Source/Tablegen.cpp           | 8 ++++----
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/Libraries/Tablegen/Include/Tablegen/Tablegen.hpp b/Libraries/Tablegen/Include/Tablegen/Tablegen.hpp
index aa97c82..84a78ef 100644
--- a/Libraries/Tablegen/Include/Tablegen/Tablegen.hpp
+++ b/Libraries/Tablegen/Include/Tablegen/Tablegen.hpp
@@ -12,17 +12,18 @@
 
 namespace Tablegen
 {
-    std::string GeneratePage(std::vector<CharacterInfo> characters,
+    std::string GeneratePage(const std::vector<CharacterInfo>& characters,
                              const Settings& settings = Settings::Default());
 
-    void GeneratePage(const std::string& path, std::vector<CharacterInfo> characters,
+    void GeneratePage(const std::string& path, const std::vector<CharacterInfo>& characters,
                       const Settings& settings = Settings::Default());
 
 #   ifdef TABLEGEN_EXPOSE_XML
-    void GenerateAsChild(pugi::xml_node& node, std::vector<CharacterInfo> characters,
+    void GenerateAsChild(pugi::xml_node& node, const std::vector<CharacterInfo>& characters,
                          const Settings& settings = Settings::Default());
 
-    pugi::xml_document GenerateDocument(std::vector<CharacterInfo> characters, const Settings& settings = Settings::Default());
+    pugi::xml_document GenerateDocument(const std::vector<CharacterInfo>& characters,
+                                        const Settings& settings = Settings::Default());
 #   endif
 }
 
diff --git a/Libraries/Tablegen/Source/Tablegen.cpp b/Libraries/Tablegen/Source/Tablegen.cpp
index 248e605..2edb766 100644
--- a/Libraries/Tablegen/Source/Tablegen.cpp
+++ b/Libraries/Tablegen/Source/Tablegen.cpp
@@ -95,7 +95,7 @@ namespace Tablegen
         }
     }
 
-    std::string GeneratePage(std::vector<CharacterInfo> characters, const Settings& settings)
+    std::string GeneratePage(const std::vector<CharacterInfo>& characters, const Settings& settings)
     {
         pugi::xml_document doc = GenerateDocument(characters, settings);
 
@@ -106,7 +106,7 @@ namespace Tablegen
         return str.str();
     }
 
-    void GeneratePage(const std::string& path, std::vector<CharacterInfo> characters,
+    void GeneratePage(const std::string& path, const std::vector<CharacterInfo>& characters,
                       const Settings& settings)
     {
         pugi::xml_document doc = GenerateDocument(characters, settings);
@@ -116,7 +116,7 @@ namespace Tablegen
         doc.save_file("test.html", "    ", formatOptions);
     }
 
-    void GenerateAsChild(pugi::xml_node& node, std::vector<CharacterInfo> characters,
+    void GenerateAsChild(pugi::xml_node& node, const std::vector<CharacterInfo>& characters,
                          const Settings& settings)
     {
         pugi::xml_node tableRoot = node;
@@ -203,7 +203,7 @@ namespace Tablegen
         script.append_child(pugi::node_pcdata).set_value(Script(indent, tagIndent, buttons));
     }
 
-    pugi::xml_document GenerateDocument(std::vector<CharacterInfo> characters,
+    pugi::xml_document GenerateDocument(const std::vector<CharacterInfo>& characters,
                                         const Settings& settings)
     {
         pugi::xml_document doc;